CVS commit: pkgsrc/devel/cmake

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Thu May  1 11:52:27 UTC 2025

Modified Files:
        pkgsrc/devel/cmake: build.mk

Log Message:
cmake/build.mk: Add comments about CMAKE_GENERATOR workaround

Explain that packages can abuse CMAKE_GENERATOR until someone
implements CMAKE_GENERATORS_ACCEPTED.  (Or perhaps fixes ninja to
handle subdir builds.)

This is a comment only change.  As discussed on tech-pkg@.


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 pkgsrc/devel/cmake/build.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/devel/cmake/build.mk
diff -u pkgsrc/devel/cmake/build.mk:1.22 pkgsrc/devel/cmake/build.mk:1.23
--- pkgsrc/devel/cmake/build.mk:1.22    Mon Jan 27 08:49:08 2025
+++ pkgsrc/devel/cmake/build.mk Thu May  1 11:52:26 2025
@@ -1,4 +1,4 @@
-# $NetBSD: build.mk,v 1.22 2025/01/27 08:49:08 adam Exp $
+# $NetBSD: build.mk,v 1.23 2025/05/01 11:52:26 gdt Exp $
 #
 # This Makefile fragment supports building using the CMake build tool.
 #
@@ -8,6 +8,13 @@
 # variable CMAKE_GENERATOR must be defined before inclusion (as it is
 # a user-settable variable that should happen automatically).
 #
+# Note that CMAKE_GENERATOR is a user-settable variable, but there is
+# no package-settable CMAKE_GENERATORS_ACCEPTED.  Therefore, when a
+# package fails to build with one of the choices of generators,
+# typically ninja, packages will, as a workaround, set CMAKE_GENERATOR
+# to the one that works, typically make.  (The typical cause is ninja
+# failing with BUILD_DIRS set to a subdirectory.
+#
 # User-settable variables:
 #
 # CMAKE_GENERATOR